pollux.dependency.onSuccess - Code Metrics - Inspection of "remove ajax activation" - pryley/pollux - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 775faa...ae8f25 )

by Paul

created 2017-05-12 15:29 UTC

pollux.dependency.onSuccess A

↳ Parent: +/main.js

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
nc	3
nop	1
dl	0
loc	11
rs	9.2
c	0
b	0
f	0

/** global: wp, pollux, CodeMirror */

pollux.dependency = {};
pollux.editors = {};
pollux.featured = {};
pollux.metabox = {};
pollux.tabs = {};

/**
 * @return bool
 */
pollux.classListAction = function( bool )
{
	return bool ? 'add' : 'remove';
};

/**
 * @return void
 */
pollux.dependency.ajax = function( action, el, type )
{
	var args = pollux.dependency.getAjaxOptions( el );
	wp.ajax.send( action, {
		_ajax_nonce: wp.updates.ajaxNonce,
		error: args.error,
		plugin: args.plugin,
		success: args.success,
		type: type,
	});
};

/**
 * @return object
 */
pollux.dependency.getAjaxOptions = function( el )
{
	return {
		error: pollux.dependency.onError.bind( el ),
		plugin: el.getAttribute( 'data-plugin' ),
		slug: el.getAttribute( 'data-slug' ),
		success: pollux.dependency.onSuccess.bind( el ),
	};
};

/**
 * @return void
 */
pollux.dependency.init = function()
{
	pollux.dependency.buttons = document.querySelectorAll( '.pollux-notice a.button' );
	[].forEach.call( pollux.dependency.buttons, function( button ) {
		button.addEventListener( 'click', pollux.dependency.onClick );
	});
};

/**
 * @return void
 */
pollux.dependency.install = function( el, args )
{
	pollux.dependency.updateButtonText( el, 'pluginInstallingLabel' );
	el.classList.add( 'updating-message' );
	return wp.updates.ajax( 'install-plugin', args );
};

/**
 * @return void
 */
pollux.dependency.onClick = function( ev )
{
	var action = this.href.match(/action=([^&]+)/);
	if( action === null )return;
if (a > 0)
    b = 42;
	action = action[1].split('-')[0];
	if( !pollux.dependency[action] )return;
if (a > 0)
    b = 42;
	this.blur();
	ev.preventDefault();
	if( this.classList.contains( 'updating-message' ))return;
if (a > 0)
    b = 42;
	pollux.dependency[action]( this, pollux.dependency.getAjaxOptions( this ));
};

/**
 * @return void
 */
pollux.dependency.onError = function( response )

{
	window.location = this.href;
};

/**
 * @return void
 */
pollux.dependency.onSuccess = function( response )
{
	var type = response.install ? 'install' : 'update';
	if( !response.activate_url ) {
		return pollux.dependency.ajax( 'pollux/dependency/activate_url', this, type );
	}
	pollux.dependency.setUpdatedMessage( this, type );
	if( response.activate_url ) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
		setTimeout( _.bind( pollux.dependency.setActivateButton( this, response ), this ), 1000 );

	}
};

/**
 * @return void
 */
pollux.dependency.setActivateButton = function( el, response )
{
	el.classList.remove( 'updated-message' );
	el.classList.remove( 'button-disabled' );
	pollux.dependency.updateButtonText( el, 'activatePluginLabel' );
	el.classList.add( 'button-primary' );
	el.href = response.activateUrl;
};

/**
 * @return void
 */
pollux.dependency.setUpdatedMessage = function( el, type )
{
	el.classList.remove( 'updating-message' );
	el.classList.add( 'updated-message' );
	el.classList.add( 'button-disabled' );
	pollux.dependency.updateButtonText( el, (
		type === 'install' ? 'pluginInstalledLabel' : 'updatedLabel'
	));
};

/**
 * @return void
 */
pollux.dependency.updateButtonText = function( el, l10nkey )
{
	if( !wp.updates.l10n[l10nkey] )return;
if (a > 0)
    b = 42;
	var label = wp.updates.l10n[l10nkey].replace( '%s', el.getAttribute( 'data-name' ));
	if( el.innerHTML !== label ) {
		el.innerHTML = label;
	}
};

/**
 * @return void
 */
pollux.dependency.upgrade = function( el, args )
{
	pollux.dependency.updateButtonText( el, 'updatingLabel' );
	el.classList.add( 'updating-message' );
	return wp.updates.ajax( 'update-plugin', args );
};

/**
 * @return void
 */
pollux.editors.disable = function( index )
{
	pollux.editors.all[index].setOption( 'theme', 'disabled' );
	pollux.editors.all[index].setOption( 'readOnly', 'nocursor' );
};

/**
 * @return void
 */
pollux.editors.enable = function( index )
{
	pollux.editors.all[index].setOption( 'theme', 'pollux' );
	pollux.editors.all[index].setOption( 'readOnly', false );
};

/**
 * @return void
 */
pollux.editors.init = function()
{
	pollux.editors.all = [];
	[].forEach.call( document.querySelectorAll( '.pollux-code' ), function( editor, index ) {
		pollux.editors.all[index] = CodeMirror.fromTextArea( editor, {
			gutters: ['CodeMirror-lint-markers'],
			highlightSelectionMatches: { wordsOnly: true },
			lineNumbers: true,
			lint: true,
			mode: 'text/yaml',
			showInvisibles: true,
			showTrailingSpace: true,
			styleActiveLine: true,
			tabSize: 2,
			theme: 'pollux',
			viewportMargin: Infinity,
		});
		pollux.editors.all[index].setOption( 'extraKeys', {
			Tab: function( cm ) {
				var spaces = Array( cm.getOption( 'indentUnit' ) + 1 ).join( ' ' );
				cm.replaceSelection( spaces );
			},
		});
		pollux.editors.all[index].display.wrapper.setAttribute( 'data-disabled', editor.getAttribute( 'data-disabled' ));
		if( editor.readOnly ) {
			pollux.editors.disable( index );
		}
	});
};

/**
 * @return void
 */
pollux.featured.init = function()
{
	jQuery( '#postimagediv' )
	.on( 'click', '#pollux-set-featured', function( ev ) {
		ev.preventDefault();
		wp.media.view.settings.post.featuredImageId = Math.round( jQuery( '#featured' ).val() );
		pollux.featured.frame = wp.media.featuredImage.frame;
		pollux.featured.frame().open();
	})
	.on( 'click', '#pollux-remove-featured', function( ev ) {
		ev.preventDefault();
		pollux.featured.set(-1);
	});
};

/**
 * @return void
 */
pollux.featured.select = function()
{
	if( !wp.media.view.settings.post.featuredImageId )return;
	var selection = this.get( 'selection' ).single();
	pollux.featured.set( selection ? selection.id : -1 );
};

/**
 * @return void
 */
pollux.featured.set = function( id )
{
	wp.media.view.settings.post.featuredImageId = Math.round( id );
	wp.media.post( 'pollux/archives/featured/html', {
		_wpnonce: document.querySelector( '#_wpnonce' ).value,
		post_type: document.querySelector( '#archive-type' ).value,
		thumbnail_id: id,
	}).done( function( html ) {
		document.querySelector( '#postimagediv > .inside' ).innerHTML = html;
	});
};

/**
 * @return bool
 */
pollux.metabox.hasValue = function( el )
{
	if( el.type === 'checkbox' ) {
		return el.checked === true;
	}
	return el.value !== '';
};

/**
 * @return void
 */
pollux.metabox.init = function()
{
	var depends = document.querySelectorAll( '.rwmb-input [data-depends]' );
	[].forEach.call( depends, function( el ) {
		var dependency = pollux.metabox.setVisibility( el );
		var event = dependency.type === 'checkbox' ? 'change' : 'keyup';
		dependency.addEventListener( event, function() {
			pollux.metabox.setVisibility( el );
		});
	});
};

/**
 * @return element
 */
pollux.metabox.setVisibility = function( el )
{
	var dependency = document.getElementById( el.getAttribute( 'data-depends' ));
	var action = pollux.classListAction( !pollux.metabox.hasValue( dependency ));
	el.closest( '.rwmb-field' ).classList[action]( 'hidden' );
	return dependency;
};

/**
 * @return void
 */
pollux.tabs.init = function()
{
	pollux.tabs.active = document.querySelector( '#pollux-active-tab' );
	pollux.tabs.referrer = document.querySelector( 'input[name="_wp_http_referer"]' );
	pollux.tabs.tabs = document.querySelectorAll( '.pollux-tabs a' );
	pollux.tabs.views = document.querySelectorAll( '.pollux-config .form-table' );

	[].forEach.call( pollux.tabs.tabs, function( tab, index ) {
		var active = location.hash ? tab.getAttribute( 'href' ).slice(1) === location.hash.slice(2) : index === 0;
		if( active ) {
			pollux.tabs.setTab( tab );
		}
		tab.addEventListener( 'click', pollux.tabs.onClick );
		tab.addEventListener( 'touchend', pollux.tabs.onClick );
	});
};

/**
 * @return void
 */
pollux.tabs.onClick = function( ev )
{
	ev.preventDefault();
	this.blur();
	pollux.tabs.setTab( this );
	location.hash = '!' + this.getAttribute( 'href' ).slice(1);
	// pollux.editors.all.forEach( function( editor ) {
	// 	editor.refresh();
	// });
};

/**
 * @return void
 */
pollux.tabs.setReferrer = function( index )
{
	var referrerUrl = pollux.tabs.referrer.value.split('#')[0] + '#!' + pollux.tabs.views[index].id;
	pollux.tabs.referrer.value = referrerUrl;
};

/**
 * @return void
 */
pollux.tabs.setTab = function( el )
{
	[].forEach.call( pollux.tabs.tabs, function( tab, index ) {
		var action = pollux.classListAction( tab === el );
		if( action === 'add' ) {
			pollux.tabs.active.value = pollux.tabs.views[index].id;
			pollux.tabs.setReferrer( index );
			pollux.tabs.setView( index );
		}
		tab.classList[action]( 'nav-tab-active' );
	});
};

/**
 * @return void
 */
pollux.tabs.setView = function( idx )
{
	[].forEach.call( pollux.tabs.views, function( view, index ) {
		var action = pollux.classListAction( index !== idx );
		view.classList[action]( 'ui-tabs-hide' );
	});
};

jQuery(function() {
	for( var key in pollux ) {
var someObject;
for (var key in someObject) {
    if ( ! someObject.hasOwnProperty(key)) {
        continue; // Skip keys from the prototype.
    }

    doSomethingWith(key);
}
		if( !pollux[key].hasOwnProperty( 'init' ))continue;
if (a > 0)
    b = 42;
		pollux[key].init();
	}
});


1			/** global: wp, pollux, CodeMirror */
2
3			pollux.dependency = {};
4			pollux.editors = {};
5			pollux.featured = {};
6			pollux.metabox = {};
7			pollux.tabs = {};
8
9			/**
10			* @return bool
11			*/
12			pollux.classListAction = function( bool )
13			{
14			return bool ? 'add' : 'remove';
15			};
16
17			/**
18			* @return void
19			*/
20			pollux.dependency.ajax = function( action, el, type )
21			{
22			var args = pollux.dependency.getAjaxOptions( el );
23			wp.ajax.send( action, {
24			_ajax_nonce: wp.updates.ajaxNonce,
25			error: args.error,
26			plugin: args.plugin,
27			success: args.success,
28			type: type,
29			});
30			};
31
32			/**
33			* @return object
34			*/
35			pollux.dependency.getAjaxOptions = function( el )
36			{
37			return {
38			error: pollux.dependency.onError.bind( el ),
39			plugin: el.getAttribute( 'data-plugin' ),
40			slug: el.getAttribute( 'data-slug' ),
41			success: pollux.dependency.onSuccess.bind( el ),
42			};
43			};
44
45			/**
46			* @return void
47			*/
48			pollux.dependency.init = function()
49			{
50			pollux.dependency.buttons = document.querySelectorAll( '.pollux-notice a.button' );
51			[].forEach.call( pollux.dependency.buttons, function( button ) {
52			button.addEventListener( 'click', pollux.dependency.onClick );
53			});
54			};
55
56			/**
57			* @return void
58			*/
59			pollux.dependency.install = function( el, args )
60			{
61			pollux.dependency.updateButtonText( el, 'pluginInstallingLabel' );
62			el.classList.add( 'updating-message' );
63			return wp.updates.ajax( 'install-plugin', args );
64			};
65
66			/**
67			* @return void
68			*/
69			pollux.dependency.onClick = function( ev )
70			{
71			var action = this.href.match(/action=([^&]+)/);
72			if( action === null )return;
			1 ignored issue – show Coding Style Best Practice introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
73			action = action[1].split('-')[0];
74			if( !pollux.dependency[action] )return;
			1 ignored issue – show Coding Style Best Practice introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
75			this.blur();
76			ev.preventDefault();
77			if( this.classList.contains( 'updating-message' ))return;
			1 ignored issue – show Coding Style Best Practice introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
78			pollux.dependency[action]( this, pollux.dependency.getAjaxOptions( this ));
79			};
80
81			/**
82			* @return void
83			*/
84			pollux.dependency.onError = function( response )
			0 ignored issues – show Unused Code introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report The parameter `response` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
85			{
86			window.location = this.href;
87			};
88
89			/**
90			* @return void
91			*/
92			pollux.dependency.onSuccess = function( response )
93			{
94			var type = response.install ? 'install' : 'update';
95			if( !response.activate_url ) {
96			return pollux.dependency.ajax( 'pollux/dependency/activate_url', this, type );
97			}
98			pollux.dependency.setUpdatedMessage( this, type );
99			if( response.activate_url ) {
			0 ignored issues – show Complexity Best Practice introduced 2017-05-12 15:32 UTC by Report Bug Copy Issue Report There is no return statement if `response.activate_url` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
100			setTimeout( _.bind( pollux.dependency.setActivateButton( this, response ), this ), 1000 );
			0 ignored issues – show Bug introduced 2017-05-12 15:32 UTC by Report Bug Copy Issue Report The variable `_` seems to be never declared. If this is a global, consider adding a `/** global: _ */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history... Best Practice introduced 2017-05-12 15:32 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
101			}
102			};
103
104			/**
105			* @return void
106			*/
107			pollux.dependency.setActivateButton = function( el, response )
108			{
109			el.classList.remove( 'updated-message' );
110			el.classList.remove( 'button-disabled' );
111			pollux.dependency.updateButtonText( el, 'activatePluginLabel' );
112			el.classList.add( 'button-primary' );
113			el.href = response.activateUrl;
114			};
115
116			/**
117			* @return void
118			*/
119			pollux.dependency.setUpdatedMessage = function( el, type )
120			{
121			el.classList.remove( 'updating-message' );
122			el.classList.add( 'updated-message' );
123			el.classList.add( 'button-disabled' );
124			pollux.dependency.updateButtonText( el, (
125			type === 'install' ? 'pluginInstalledLabel' : 'updatedLabel'
126			));
127			};
128
129			/**
130			* @return void
131			*/
132			pollux.dependency.updateButtonText = function( el, l10nkey )
133			{
134			if( !wp.updates.l10n[l10nkey] )return;
			1 ignored issue – show Coding Style Best Practice introduced 2017-05-12 15:32 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
135			var label = wp.updates.l10n[l10nkey].replace( '%s', el.getAttribute( 'data-name' ));
136			if( el.innerHTML !== label ) {
137			el.innerHTML = label;
138			}
139			};
140
141			/**
142			* @return void
143			*/
144			pollux.dependency.upgrade = function( el, args )
145			{
146			pollux.dependency.updateButtonText( el, 'updatingLabel' );
147			el.classList.add( 'updating-message' );
148			return wp.updates.ajax( 'update-plugin', args );
149			};
150
151			/**
152			* @return void
153			*/
154			pollux.editors.disable = function( index )
155			{
156			pollux.editors.all[index].setOption( 'theme', 'disabled' );
157			pollux.editors.all[index].setOption( 'readOnly', 'nocursor' );
158			};
159
160			/**
161			* @return void
162			*/
163			pollux.editors.enable = function( index )
164			{
165			pollux.editors.all[index].setOption( 'theme', 'pollux' );
166			pollux.editors.all[index].setOption( 'readOnly', false );
167			};
168
169			/**
170			* @return void
171			*/
172			pollux.editors.init = function()
173			{
174			pollux.editors.all = [];
175			[].forEach.call( document.querySelectorAll( '.pollux-code' ), function( editor, index ) {
176			pollux.editors.all[index] = CodeMirror.fromTextArea( editor, {
177			gutters: ['CodeMirror-lint-markers'],
178			highlightSelectionMatches: { wordsOnly: true },
179			lineNumbers: true,
180			lint: true,
181			mode: 'text/yaml',
182			showInvisibles: true,
183			showTrailingSpace: true,
184			styleActiveLine: true,
185			tabSize: 2,
186			theme: 'pollux',
187			viewportMargin: Infinity,
188			});
189			pollux.editors.all[index].setOption( 'extraKeys', {
190			Tab: function( cm ) {
191			var spaces = Array( cm.getOption( 'indentUnit' ) + 1 ).join( ' ' );
192			cm.replaceSelection( spaces );
193			},
194			});
195			pollux.editors.all[index].display.wrapper.setAttribute( 'data-disabled', editor.getAttribute( 'data-disabled' ));
196			if( editor.readOnly ) {
197			pollux.editors.disable( index );
198			}
199			});
200			};
201
202			/**
203			* @return void
204			*/
205			pollux.featured.init = function()
206			{
207			jQuery( '#postimagediv' )
208			.on( 'click', '#pollux-set-featured', function( ev ) {
209			ev.preventDefault();
210			wp.media.view.settings.post.featuredImageId = Math.round( jQuery( '#featured' ).val() );
211			pollux.featured.frame = wp.media.featuredImage.frame;
212			pollux.featured.frame().open();
213			})
214			.on( 'click', '#pollux-remove-featured', function( ev ) {
215			ev.preventDefault();
216			pollux.featured.set(-1);
217			});
218			};
219
220			/**
221			* @return void
222			*/
223			pollux.featured.select = function()
224			{
225			if( !wp.media.view.settings.post.featuredImageId )return;
226			var selection = this.get( 'selection' ).single();
227			pollux.featured.set( selection ? selection.id : -1 );
228			};
229
230			/**
231			* @return void
232			*/
233			pollux.featured.set = function( id )
234			{
235			wp.media.view.settings.post.featuredImageId = Math.round( id );
236			wp.media.post( 'pollux/archives/featured/html', {
237			_wpnonce: document.querySelector( '#_wpnonce' ).value,
238			post_type: document.querySelector( '#archive-type' ).value,
239			thumbnail_id: id,
240			}).done( function( html ) {
241			document.querySelector( '#postimagediv > .inside' ).innerHTML = html;
242			});
243			};
244
245			/**
246			* @return bool
247			*/
248			pollux.metabox.hasValue = function( el )
249			{
250			if( el.type === 'checkbox' ) {
251			return el.checked === true;
252			}
253			return el.value !== '';
254			};
255
256			/**
257			* @return void
258			*/
259			pollux.metabox.init = function()
260			{
261			var depends = document.querySelectorAll( '.rwmb-input [data-depends]' );
262			[].forEach.call( depends, function( el ) {
263			var dependency = pollux.metabox.setVisibility( el );
264			var event = dependency.type === 'checkbox' ? 'change' : 'keyup';
265			dependency.addEventListener( event, function() {
266			pollux.metabox.setVisibility( el );
267			});
268			});
269			};
270
271			/**
272			* @return element
273			*/
274			pollux.metabox.setVisibility = function( el )
275			{
276			var dependency = document.getElementById( el.getAttribute( 'data-depends' ));
277			var action = pollux.classListAction( !pollux.metabox.hasValue( dependency ));
278			el.closest( '.rwmb-field' ).classList[action]( 'hidden' );
279			return dependency;
280			};
281
282			/**
283			* @return void
284			*/
285			pollux.tabs.init = function()
286			{
287			pollux.tabs.active = document.querySelector( '#pollux-active-tab' );
288			pollux.tabs.referrer = document.querySelector( 'input[name="_wp_http_referer"]' );
289			pollux.tabs.tabs = document.querySelectorAll( '.pollux-tabs a' );
290			pollux.tabs.views = document.querySelectorAll( '.pollux-config .form-table' );
291
292			[].forEach.call( pollux.tabs.tabs, function( tab, index ) {
293			var active = location.hash ? tab.getAttribute( 'href' ).slice(1) === location.hash.slice(2) : index === 0;
294			if( active ) {
295			pollux.tabs.setTab( tab );
296			}
297			tab.addEventListener( 'click', pollux.tabs.onClick );
298			tab.addEventListener( 'touchend', pollux.tabs.onClick );
299			});
300			};
301
302			/**
303			* @return void
304			*/
305			pollux.tabs.onClick = function( ev )
306			{
307			ev.preventDefault();
308			this.blur();
309			pollux.tabs.setTab( this );
310			location.hash = '!' + this.getAttribute( 'href' ).slice(1);
311			// pollux.editors.all.forEach( function( editor ) {
312			// editor.refresh();
313			// });
314			};
315
316			/**
317			* @return void
318			*/
319			pollux.tabs.setReferrer = function( index )
320			{
321			var referrerUrl = pollux.tabs.referrer.value.split('#')[0] + '#!' + pollux.tabs.views[index].id;
322			pollux.tabs.referrer.value = referrerUrl;
323			};
324
325			/**
326			* @return void
327			*/
328			pollux.tabs.setTab = function( el )
329			{
330			[].forEach.call( pollux.tabs.tabs, function( tab, index ) {
331			var action = pollux.classListAction( tab === el );
332			if( action === 'add' ) {
333			pollux.tabs.active.value = pollux.tabs.views[index].id;
334			pollux.tabs.setReferrer( index );
335			pollux.tabs.setView( index );
336			}
337			tab.classList[action]( 'nav-tab-active' );
338			});
339			};
340
341			/**
342			* @return void
343			*/
344			pollux.tabs.setView = function( idx )
345			{
346			[].forEach.call( pollux.tabs.views, function( view, index ) {
347			var action = pollux.classListAction( index !== idx );
348			view.classList[action]( 'ui-tabs-hide' );
349			});
350			};
351
352			jQuery(function() {
353			for( var key in pollux ) {
			0 ignored issues – show Complexity introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report A for in loop automatically includes the property of any prototype object, consider checking the key using `hasOwnProperty`. When iterating over the keys of an object, this includes not only the keys of the object, but also keys contained in the prototype of that object. It is generally a best practice to check for these keys specifically: var someObject; for (var key in someObject) { if ( ! someObject.hasOwnProperty(key)) { continue; // Skip keys from the prototype. } doSomethingWith(key); } Loading history...
354			if( !pollux[key].hasOwnProperty( 'init' ))continue;
			1 ignored issue – show Coding Style Best Practice introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
355			pollux[key].init();
356			}
357			});
358

pryley / pollux

Push — develop ( 775faa...ae8f25 )

pollux.dependency.onSuccess A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like